Add support for x_only = True extra metrics during table generation #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
This pull request was exported from Phabricator. Differential Revision: D58435001 |
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
This pull request was exported from Phabricator. Differential Revision: D58435001 |
jananisriram
added a commit
to jananisriram/benchmark
that referenced
this pull request
Jun 12, 2024
…ytorch#2294) Summary: Pull Request resolved: pytorch#2294 Add support for extra metrics that are the same across all benchmark implementations, identified by the `x_only = True` argument for [`register_metric()`](https://www.internalfb.com/code/fbsource/[dde2970b470a85612b904a14825aa7f0998f1658]/fbcode/pytorch/benchmark/torchbenchmark/util/triton_op.py?lines=328). This diff supports additional functionality in D58396957, where the current implementation did not support adding new metrics with `x_only = True`. Reviewed By: xuzhao9 Differential Revision: D58435001
jananisriram
force-pushed
the
export-D58435001
branch
from
9e98cd0 to
c87ccb8
Compare
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
approved these changes
Jun 12, 2024
|
This pull request was exported from Phabricator. Differential Revision: D58435001 |
jananisriram
added a commit
to jananisriram/benchmark
that referenced
this pull request
Jun 12, 2024
…ytorch#2294) Summary: Pull Request resolved: pytorch#2294 Add support for extra metrics that are the same across all benchmark implementations, identified by the `x_only = True` argument for [`register_metric()`](https://www.internalfb.com/code/fbsource/[dde2970b470a85612b904a14825aa7f0998f1658]/fbcode/pytorch/benchmark/torchbenchmark/util/triton_op.py?lines=328). This diff supports additional functionality in D58396957, where the current implementation did not support adding new metrics with `x_only = True`. Reviewed By: xuzhao9 Differential Revision: D58435001
jananisriram
force-pushed
the
export-D58435001
branch
from
c87ccb8 to
8108026
Compare
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
This pull request was exported from Phabricator. Differential Revision: D58435001 |
jananisriram
added a commit
to jananisriram/benchmark
that referenced
this pull request
Jun 12, 2024
…ytorch#2294) Summary: Pull Request resolved: pytorch#2294 Add support for extra metrics that are the same across all benchmark implementations, identified by the `x_only = True` argument for [`register_metric()`](https://www.internalfb.com/code/fbsource/[dde2970b470a85612b904a14825aa7f0998f1658]/fbcode/pytorch/benchmark/torchbenchmark/util/triton_op.py?lines=328). This diff supports additional functionality in D58396957, where the current implementation did not support adding new metrics with `x_only = True`. Reviewed By: xuzhao9 Differential Revision: D58435001
jananisriram
force-pushed
the
export-D58435001
branch
from
8108026 to
51504cc
Compare
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
jananisriram
added a commit
to jananisriram/benchmark
that referenced
this pull request
Jun 12, 2024
…ytorch#2294) Summary: Pull Request resolved: pytorch#2294 Add support for extra metrics that are the same across all benchmark implementations, identified by the `x_only = True` argument for [`register_metric()`](https://www.internalfb.com/code/fbsource/[dde2970b470a85612b904a14825aa7f0998f1658]/fbcode/pytorch/benchmark/torchbenchmark/util/triton_op.py?lines=328). This diff supports additional functionality in D58396957, where the current implementation did not support adding new metrics with `x_only = True`. Reviewed By: xuzhao9 Differential Revision: D58435001
|
This pull request was exported from Phabricator. Differential Revision: D58435001 |
jananisriram
force-pushed
the
export-D58435001
branch
from
51504cc to
e9a3896
Compare
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
jananisriram
added a commit
to jananisriram/benchmark
that referenced
this pull request
Jun 12, 2024
…ytorch#2294) Summary: Pull Request resolved: pytorch#2294 Add support for extra metrics that are the same across all benchmark implementations, identified by the `x_only = True` argument for [`register_metric()`](https://www.internalfb.com/code/fbsource/[dde2970b470a85612b904a14825aa7f0998f1658]/fbcode/pytorch/benchmark/torchbenchmark/util/triton_op.py?lines=328). This diff supports additional functionality in D58396957, where the current implementation did not support adding new metrics with `x_only = True`. Reviewed By: xuzhao9 Differential Revision: D58435001
|
This pull request was exported from Phabricator. Differential Revision: D58435001 |
jananisriram
force-pushed
the
export-D58435001
branch
from
e9a3896 to
93ca63c
Compare
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
…ytorch#2294) Summary: Pull Request resolved: pytorch#2294 Add support for extra metrics that are the same across all benchmark implementations, identified by the `x_only = True` argument for [`register_metric()`](https://www.internalfb.com/code/fbsource/[dde2970b470a85612b904a14825aa7f0998f1658]/fbcode/pytorch/benchmark/torchbenchmark/util/triton_op.py?lines=328). This diff supports additional functionality in D58396957, where the current implementation did not support adding new metrics with `x_only = True`. Reviewed By: xuzhao9 Differential Revision: D58435001
jananisriram
force-pushed
the
export-D58435001
branch
from
93ca63c to
9d4b486
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58435001 |
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
jananisriram
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
|
This pull request has been merged in 217d8f8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add support for extra metrics that are the same across all benchmark implementations, identified by the
x_only = Trueargument forregister_metric(). This diff supports additional functionality in D58396957, where the current implementation did not support adding new metrics withx_only = True.Reviewed By: xuzhao9
Differential Revision: D58435001